Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talk about git submodules #915

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Talk about git submodules #915

merged 2 commits into from
Oct 10, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Helps with #850.
cc @jyn514

@jyn514 jyn514 self-assigned this Oct 7, 2020
@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 7, 2020
jyn514
jyn514 reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @thomcc - does this make you a little more comfortable with submodules?

src/git.md Outdated Show resolved Hide resolved
src/git.md Show resolved Hide resolved
@jyn514 jyn514 added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Oct 7, 2020
@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Oct 10, 2020
@LeSeulArtichaut
Apply suggestions from code review
fdf4c92 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
jyn514
jyn514 approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can make improvements in follow-ups.

@jyn514 jyn514 merged commit 50f1e77 into rust-lang:master Oct 10, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the git-submodules branch October 10, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees

@jyn514 jyn514

Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeSeulArtichaut @jyn514 @camelid